Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: interceptor http method도 지정하게 변경 #588

Open
wants to merge 2 commits into
base: BE/develop
Choose a base branch
from
Open

refactor: interceptor http method도 지정하게 변경 #588

wants to merge 2 commits into from

Conversation

kevstevie
Copy link
Collaborator

😋 작업한 내용

인터셉터로 http method도 필터링 가능하게 수정했습니다
예외가 있다면 말씀해주세요

🙏 PR Point

👍 관련 이슈

기획의 어떤 부분을 구현 / 수정했는가 (굉장히 상세하게 적어주세요, 해당 커밋의 링크, 코드의 위치를 남겨주면 더욱 좋습니다.)

밑은 예시입니다.

시작되면서 스터디의 주 몇 회 정보를 유저가 실제로 선택한 일 수로 수정

  • StudyService의 createStudy 메서드에서 PeriodOfRound 를 받지 않도록 수정했습니다. 해당커밋
  • Study의 start 메서드에서 파라미터로 시작한 날짜를 받도록 구현하였습니다.
  • 날짜(월화수목금토일)를 뜻하는 Enum을 Study 패키지에 추가하였습니다.
  • flyway에서 해당 엔티티에 필요할 칼럼을 수정했습니다.

스터디가 더 이상 종료되지 않도록 수정

  • 상동

@kevstevie kevstevie added backend🤎 백엔드 refactor 리팩터링 labels Oct 28, 2023
@kevstevie kevstevie self-assigned this Oct 28, 2023
@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

Test Results

111 tests   111 ✔️  19s ⏱️
  22 suites      0 💤
  22 files        0 ❌

Results for commit ebbf789.

♻️ This comment has been updated with latest results.

CFalws
CFalws approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@CFalws CFalws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 구현하셨네요!
딱히 문제가 될 부분은 없어보입니다.
👍

yujamint
yujamint approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@yujamint yujamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요~ 제가 깬 유리창 잘 보수해 주서서 감사합니다 ㅋㅋㅋ

backend/src/main/java/com/yigongil/backend/config/auth/path/HttpMethod.java
GET,
PATCH,
DELETE,
ANY {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CFalws CFalws CFalws approved these changes

@yujamint yujamint yujamint approved these changes

@poi1649 poi1649 Awaiting requested review from poi1649 poi1649 is a code owner

Assignees

@kevstevie kevstevie

Labels
backend🤎 백엔드 refactor 리팩터링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevstevie @yujamint @CFalws @poi1649